Project

General

Profile

Actions

Bug #16573

open

smntemp Tctl is not degrees C

Added by Robert Mustacchi 25 days ago. Updated 25 days ago.

Status:
New
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Currently the smntemp(4D) driver suggests that the control temperature that we read from the SMN is in degrees C. This is incorrect. AMD says that this is Tctl and not Tdie. Further, there is no simple relationship between the two. While the Ryzen Master software suggested this based on a form post, the PPR tells a more complex story.

Instead, we should be up front that this is a dimensionless temperature. In addition, we've found some additional challenges here with the data in SMU::THM::THM_TCON_CUR_TMP:

  • We need to look at CUR_TEMP_TJ_SEL to determine what unit this value is truly in, as it may be a junction temperature.
  • Some systems have SMU::THM::THM_TCON_CUR_TMP[CUR_TEMP_TJ_SEL] == 3 but have not set CUR_TEMP_RANGE_SEL. We received confirmation from AMD that this still needs to have adjustments taken.
  • While the PPR suggests aspects of this are writable, the SMN ::THM::THM_TCON_CUR_TMP is just a shadow.

This needs to get cleaned up along with making it clear what unit this in.


Related issues

Related to illumos gate - Feature #16575: ksensor/topo support for synthetic sensorsNewRobert Mustacchi

Actions
Related to illumos gate - Feature #16574: smntemp CCD Tdie supportNewRobert Mustacchi

Actions
Related to illumos gate - Feature #16577: libtopo sensor property translations truncate valuesNewRobert Mustacchi

Actions
Actions #1

Updated by Robert Mustacchi 25 days ago

  • Related to Feature #16575: ksensor/topo support for synthetic sensors added
Actions #2

Updated by Robert Mustacchi 25 days ago

Actions #3

Updated by Robert Mustacchi 25 days ago

  • Related to Feature #16577: libtopo sensor property translations truncate values added
Actions #4

Updated by Electric Monk 25 days ago

  • Gerrit CR set to 3526
Actions

Also available in: Atom PDF