Project

General

Profile

Actions

Bug #16591

open

nvme_field_validate swallows more specific error messages

Added by Andy Fiddaman 12 days ago. Updated 12 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

While investigating a problem with loading firmware to a Micron NVMe M.2 drive, the real cause of the issue was a mismatch between the firmware update granularity being used and the input file. However, the error was simply:

# nvmeadm load-firmware nvme0 /tmp/micron_7300_fw-95420280_m2.tar
nvmeadm: failed to load firmware image "/tmp/micron_7300_fw-95420280_m2.tar" at offset 7012352:
field number of dwords (numd) value 0xaa00 is invalid: NVME_ERR_FW_LOAD_LEN_RANGE
(libnvme: 0x38, sys: 0)

dtrace shows that a more useful error message is actually there before being overwritten with the generic one:

112  74383               nvme_fw_load:entry fffff5ffffde8c30 aa00 6b0000
112  74384       nvme_field_check_one:entry aa00
112  74385 nvme_fw_load_field_valid_len:entry aa00
112  74387  nvme_fw_load_granularity:return 1000
112  74386 nvme_fw_load_field_valid_len:return 0
string "number of dwords (numd) value 0xaa00 must be aligned to the firmware update granularity 0x1000" 
112  74388            nvme_ctrl_error:entry string "field number of dwords (numd) value 0xaa00 is invalid" 

Related issues

Related to illumos gate - Bug #16592: Cannot update NVMe firmware on Micron 7300In ProgressAndy Fiddaman

Actions
Actions #1

Updated by Andy Fiddaman 12 days ago

  • Description updated (diff)
Actions #2

Updated by Andy Fiddaman 12 days ago

  • Related to Bug #16592: Cannot update NVMe firmware on Micron 7300 added
Actions #3

Updated by Electric Monk 12 days ago

  • Gerrit CR set to 3536
Actions

Also available in: Atom PDF