Project

General

Profile

Bug #1663

Non-empty directories can be marked delete on close in CIFS, but not actually deleted

Added by Albert Lee almost 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cifs - CIFS server and client
Start date:
2011-10-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

We're affected by an issue where a client is allowed to set the delete on close flag on a directory, but the server will fail to delete the directory without informing the client because it is non-empty at the time of close.
The characteristic message from smbsrv is: WARNING: File <name> could not be removed, rc=17.

Further details:
http://opensolaris.org/jive/thread.jspa?threadID=113547
http://mail.opensolaris.org/pipermail/cifs-discuss/2010-September/003262.html
"This DOES appear to be the issue where we allow a
non-empty directory to be marked for deletion on
close, when indeed the delete will fail due to the
directory not being empty."

http://www.nexenta.org/boards/1/topics/1035 has packet traces.

Also as Bugster 6984617 Setting Delete on close on non-empty directory returns success, but directory will not be deleted.


Related issues

Related to illumos gate - Bug #5901: SMB clients get errors trying to delete non-empty directoriesClosed2015-05-02

Actions

History

#1

Updated by Andrew Stormont over 4 years ago

  • Related to Bug #5901: SMB clients get errors trying to delete non-empty directories added
#2

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 5496c1178a1a48006226450b13c2df195831794c

commit  5496c1178a1a48006226450b13c2df195831794c
Author: Alek Pinchuk <alek@nexenta.com>
Date:   2015-05-08T14:38:39.000Z

    5901 SMB clients get errors trying to delete non-empty directories
    1663 Non-empty directories can be marked delete on close in CIFS, but not actually deleted
    Reviewed by: Bayard Bell <buffer.g.overflow@gmail.com>
    Reviewed by: Gordon Ross <gwr@nexenta.com>
    Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF