Project

General

Profile

Bug #1666

libwrap is 32bit only

Added by Andrew Stormont almost 8 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
lib - userland libraries
Start date:
2011-10-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Illumos does not provide a 64bit libwrap and it looks like the reason is because it currently uses sys_errlist and sys_nerr which are only available in 32bit libc. I've attached the patch I use in StormOS which changes libwrap to use strerror and adds a 64bit version in the hope that it will be helpful.


Files

libwrap-64.diff (3.48 KB) libwrap-64.diff Andrew Stormont, 2011-10-18 10:05 PM
libwrap64-git.patch (5.74 KB) libwrap64-git.patch Alexander Pyhalov, 2013-10-12 04:10 PM

Related issues

Related to illumos gate - Bug #3510: libwrap 64 bit build failedClosed2013-01-31

Actions

History

#1

Updated by Alexander Pyhalov almost 6 years ago

The following patch enables 64-bit libwrap (also includes manifests changes). Tested it on recent illumos (4f9a6360ccbecd9ff675131a0d72925cdde1b18b) with php-tcpwrappers 64-bit module.

#2

Updated by Andrew Stormont almost 6 years ago

I don't think this is going to work as you expect because strerror does not alter errno. Your code will always return "Unknown [UNIX ]error". It's worth noting that strerror will return "Unknown error" if the errno is not recognised. I felt this was acceptable and that's why the original patch is like it is. I'm happy to see that someone cares enough about this to contribute though.

Thanks,
Andy.

#3

Updated by Alexander Pyhalov almost 6 years ago

I'm not sure, but man strerror says:

Upon successful completion, strerror() returns a pointer  to
the generated message string. Otherwise, it sets errno and
returns a pointer to an error message string. It returns the
string "Unknown error" if errnum is not a valid error
number.
#4

Updated by Alexander Pyhalov almost 6 years ago

Ok. Got it.

#5

Updated by Robert Mustacchi over 5 years ago

  • Category set to lib - userland libraries
  • Status changed from New to Resolved
  • Assignee set to Alek Pinchuk
  • % Done changed from 0 to 100
  • Tags deleted (needs-triage)

Resolved in 9584cebb1c69707f4c67306b661c2ed47d8676f1.

#6

Updated by Alek Pinchuk over 5 years ago

  • Assignee deleted (Alek Pinchuk)

I wasn't the author of this change and I'm unable to set assignee to Alexander Pyhalov :(

Also available in: Atom PDF