Bug #1672

BAT: assertion failed: len == 0, file: ../../common/fs/zfs/zfs_vnops.c, line: 4200

Added by Vitaliy Gusev over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2011-10-20
Priority:High Due date:
Assignee:Vitaliy Gusev % Done:

100%

Category:- Spent time: -
Target version:-
Difficulty:Medium Tags:needs-triage

Description

panic[cpu0]/thread=ffffff00fbe58bc0:
assertion failed: len == 0, file: ../../common/fs/zfs/zfs_vnops.c, line: 4200

ffffff0004c5f470 genunix:assfail+7e ()
ffffff0004c5f530 zfs:zfs_putpage+373 ()
ffffff0004c5f5a0 genunix:fop_putpage+74 ()
ffffff0004c5f6c0 nfssrv:mds_op_commit+1bf ()
ffffff0004c5f730 nfssrv:rfs41_op_dispatch+9d ()
ffffff0004c5f7b0 nfssrv:mds_compound+199 ()
ffffff0004c5f850 nfssrv:rfs41_dispatch+193 ()
ffffff0004c5f890 nfssrv:rfs4_minor_version_dispatch+53 ()
ffffff0004c5fb90 nfssrv:common_dispatch+7ad ()
ffffff0004c5fbb0 nfssrv:rfs_dispatch+2d ()
ffffff0004c5fca0 rpcmod:svc_getreq+20d ()
ffffff0004c5fd10 rpcmod:svc_run+19a ()
ffffff0004c5fd40 rpcmod:svc_do_run+81 ()
ffffff0004c60eb0 nfs:nfssys+9e5 ()
ffffff0004c60f00 unix:brand_sys_syscall32+272 ()

History

Updated by Vitaliy Gusev over 2 years ago

mds_op_commit:

error = VOP_PUTPAGE(vp, args->offset, args->count, 0, cr, &ct);
if (!error)
error = VOP_FSYNC(vp, FNODSYNC, cr, &ct);

Updated by Vitaliy Gusev over 2 years ago

Original code (from Illumos-gate) had this issue also but was changed by commit:

changeset:   11894:c2da670cddda
user: Jeff A. Smith <>
date: Thu Mar 11 15:21:56 2010 -0600
files: usr/src/uts/common/fs/nfs/nfs3_srv.c usr/src/uts/common/fs/nfs/nfs4_srv.c
description:
6655655 Single phase COMMIT processing for NFS3 and NFS4 server

Updated by Vitaliy Gusev over 2 years ago

  • Assignee set to Vitaliy Gusev

Updated by Vitaliy Gusev over 2 years ago

So modify code for nfs4.1 accordingly this commit 11894:c2da670cddda.

Do FSYNC for whole file is not good so also waits for resolving bug #1732

Updated by Vitaliy Gusev over 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Fixed in changeset: 13673:28101d887ccb "nfs41: Don't call VOP_PUTPAGE during handle COMMIT"

Also available in: Atom PDF