Project

General

Profile

Bug #1690

Bug #1450: Illumos should be buildable with GCC4

getfstype() should not be modstubbed

Added by Rich Lowe almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
kernel
Start date:
2011-10-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

on SPARC, a modstub for getfstype() is declared, despite getfstype() being static and thus only called from swapgeneric.

Since getfstype is static, external callers should not exist, and again because it is static the presence of the modstub causes problems and confusion for GCC4.

I believe that the modstub is unnecessary. I had entertained the theory that perhaps it existed to allow for compatibility, where non-swapgeneric callers of getfstype() perhaps previously existed. I now believe that this is unlikely, as getfstype() is, also, where boot -a is implemented. External callers are unlikely to be intending to prompt the user again, and thus should any caller exist (unlikely) they're also doing something very wrong.

In short, we should drop the getfstype modstub on SPARC (a stub on x86 does not exist).

History

#1

Updated by Rich Lowe almost 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 60 to 100

Resolved in r13504 commit:33ca39863c11

Also available in: Atom PDF