Project

General

Profile

Bug #1716

Bug #1450: Illumos should be buildable with GCC4

libparted workaround for PGC compiler bug annoys new gcc

Added by Rich Lowe almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2011-11-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

libparted contains a workaround for a bug in the PGC compiler, the method of detection of which annoys GCC4 (for similar reasons).

-#elif BITSET_WORD_MAX == (0xffffffff + 2) * 0xffffffff
-/* Work around a bug in 64-bit PGC (before version 6.1-2), where the
-   preprocessor mishandles large unsigned values as if they were signed.  */
-# define BITSET_WORD_BITS 64

Complains of implicit overflow in the preprocessor conditionals. No amount of U, L or UL qualifiers would pacify this and, since it's a workaround for a bug in a specific compiler we don't use, it seems best to remove the offending branch than think too hard about keeping it working.

History

#1

Updated by Rich Lowe almost 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 60 to 100

Resolved in r13505 commit:d06112a5a8d9

Also available in: Atom PDF