Bug #1718

MacOS X Lion (10.7) Finder access denied

Added by Gordon Ross almost 5 years ago. Updated 5 months ago.

Status:ResolvedStart date:2011-11-03
Priority:NormalDue date:
Assignee:Gordon Ross% Done:

100%

Category:-
Target version:-
Difficulty:Medium Tags:needs-triage

Description

Finder in MacOS 10.7 connecting to illumos native SMB service gets access denied.

(Nexenta issue 6809)

illumos1718.patch Magnifier (459 Bytes) Gordon Ross, 2011-11-03 01:49 AM

History

#1 Updated by Gordon Ross almost 5 years ago

Comparing snoop traces from MacOS 10.6 and 10.7:

The only differences between 10.6 and 10.7 is the requested access.
In 10.6 the client passes access_mask = 1 (read access) and in 10.7
the client passes access_mask = 0 (no access). We currently return
access denied for Create&X with access_mask==0.

Ideally, MacOS should not send access_mask==0 here.

On the other hand, Windows will gratuitously assume you
want "read_control" in your access with NtCreateFile, and
just adds that on the server side. That's why this MacOS
10.7 client works with Windows.

The result is: we need to do like windows here.

#2 Updated by Gordon Ross almost 5 years ago

one-line fix!

#3 Updated by Gordon Ross almost 5 years ago

  • % Done changed from 80 to 100
  • Status changed from New to Resolved
changeset:   13513:f84d4672fdbd
tag:         tip
user:        Gordon Ross <gwr@nexenta.com>
date:        Wed Nov 09 18:47:36 2011 -0500

description:
    1718 MacOS X Lion (10.7) Finder access denied
    Reviewed by: Dan McDonald <danmcd@nexenta.com>
    Reviewed by: Albert Lee <trisk@nexenta.com>
    Reviewed by: Andrew Stormont <Andrew.Stormont@nexenta.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Approved by: Eric Schrock <eric.schrock@delphix.com>

modified:
   usr/src/uts/common/fs/smbsrv/smb_common_open.c

#4 Updated by Adam K-F over 4 years ago

Can we get a "target_release" tag installed here? I'm curious to see whether this patch will be included in 151 stable?

#5 Updated by Matt Connolly over 4 years ago

Adam K-F wrote:

Can we get a "target_release" tag installed here? I'm curious to see whether this patch will be included in 151 stable?

Take a look at the source tree: http://hg.openindiana.org/sustaining/oi_151a/illumos-gate/summary

If you follow the graph or commit history, you will see it is in the prestable build already. I'm running it on two machines already, no problems.

#6 Updated by Andrew Stormont 5 months ago

This fix seems to have been reverted as part of #6399. Was that intentional?

#7 Updated by Yuri Pankov 5 months ago

Andrew Stormont wrote:

This fix seems to have been reverted as part of #6399. Was that intentional?

See the changes to desired_access below (with comments) in smb_open_subr(). Do you have any access issues after #6399?

Also available in: Atom