Project

General

Profile

Bug #1726

Removal of pyzfs broke delegation for volumes

Added by John Kennedy almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2011-11-03
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Illumos issue 278 removed the use of pyzfs from zfs_main.c. The C
implementation of zfs_do_allow that replaced it calls zfs_open() with
ZFS_TYPE_FILESYSTEM, neglecting the volume type. This causes all allow
and unallow operations to fail for volumes. pyzfs used directly from
the command line still works though.

zfstest% zfs list rtall -o name,type rpool/test
NAME TYPE
rpool/test filesystem
rpool/test/vol volume
zfstest% sudo zfs allow jkennedy snapshot rpool/test/vol
cannot open 'rpool/test/vol': operation not applicable to datasets of this type
Failed to open Dataset rpool/test/vol
zfstest% sudo /usr/lib/zfs/pyzfs.py allow jkennedy snapshot rpool/test/vol
zfstest% sudo /usr/lib/zfs/pyzfs.py allow rpool/test/vol
---
Permissions on rpool/test/vol -----------------------------------
Local+Descendent permissions:
user jkennedy snapshot
zfstest% sudo zfs snapshot rpool/test/vol@test
zfstest% zfs list -rtall -o name,type rpool/test
NAME TYPE
rpool/test filesystem
rpool/test/vol volume
rpool/test/vol@test snapshot

The use of the asterisks in the error message is also quite unlike
anything I've seen from zfs errors in the past.

History

#1

Updated by Alexander Eremin almost 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Alexander Eremin
  • % Done changed from 0 to 20
#2

Updated by Garrett D'Amore almost 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 100
  • Tags deleted (needs-triage)

Pushed in

changeset: 13540:97a48b559488
tag: tip
user: Alexander Eremin <>
date: Mon Nov 28 02:13:54 2011 -0800
description:
1726 Removal of pyzfs broke delegation for volumes
Reviewed by: Andrew Stormont <>
Reviewed by: Garrett D'Amore <>
Reviewed by: Richard Lowe <>
Reviewed by: Albert Lee <>
Approved by: Garrett D'Amore <>

Also available in: Atom PDF