Project

General

Profile

Bug #1746

13509: add ZFS "clones" property causes FTBFS

Added by Andrew Stormont over 8 years ago. Updated over 8 years ago.

Status:
Feedback
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2011-11-08
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Changeset 13509 added some new prototypes to libzfs.h but libzfs uses "#include <libzfs.h>" so the installed header is used instead of the included one which is missing the new prototypes, causing a FTBFS. I hope that makes sense.

The attached patch fixes the issue for me.

Files

libzfs-fixes.diff (4.45 KB) libzfs-fixes.diff Andrew Stormont, 2011-11-08 01:09 AM

History

#1

Updated by Rich Lowe over 8 years ago

  • Status changed from New to Feedback

Something is wrong with your build environment. We specify paths via -I such that include finds workspace headers first.

The common way to run into this problem legitimately is to be using bldenv, and not re-run 'make setup' or 'make install_h'.

#2

Updated by Andrew Stormont over 8 years ago

I guess it's my fault then for doing an incremental build after pulling. Still... aren't these changes reasonable?

#3

Updated by Rich Lowe over 8 years ago

An incremental (nightly -i) should have worked. It actually sounds like you somehow don't have ENVCPPFLAGS* set (or have them mis-set).

I'm not sure on reasonableness. We have previously used <> includes pretty much exclusively, but I've never looked into why. Perhaps the cstyle pdf says something?

Also available in: Atom PDF