Project

General

Profile

Actions

Bug #1764

closed

smbsrv keep_alive timer is dead code

Added by Gordon Ross over 10 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Start date:
2011-11-11
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

The smbsrv code maintains a session->keep_alive member (with timers decrementing it and everything:) but then does not use it.

This is a hold-over from when NetBIOS keepalive was useful.
We set the TCP-level KEEPALIVE option, which is sufficient,
and the recommended way to handle this now.

Someone should go through and rip out the keep_alive member
and the code that updates it: $SRC/uts/common/fs/smbsrv/smb_session.c

Actions #1

Updated by Gordon Ross over 10 years ago

  • Priority changed from Normal to Low
  • Difficulty changed from Medium to Bite-size
Actions #2

Updated by Gordon Ross over 1 year ago

  • Status changed from New to Closed

This was cleaned up some time ago via other issues.

Actions

Also available in: Atom PDF