Bug #1764

smbsrv keep_alive timer is dead code

Added by Gordon Ross almost 7 years ago. Updated almost 7 years ago.

Status:NewStart date:2011-11-11
Priority:LowDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Difficulty:Bite-size Tags:needs-triage

Description

The smbsrv code maintains a session->keep_alive member (with timers decrementing it and everything:) but then does not use it.

This is a hold-over from when NetBIOS keepalive was useful.
We set the TCP-level KEEPALIVE option, which is sufficient,
and the recommended way to handle this now.

Someone should go through and rip out the keep_alive member
and the code that updates it: $SRC/uts/common/fs/smbsrv/smb_session.c

History

#1 Updated by Gordon Ross almost 7 years ago

  • Priority changed from Normal to Low
  • Difficulty changed from Medium to Bite-size

Also available in: Atom