Project

General

Profile

Actions

Bug #1802

closed

Bug #1450: Illumos should be buildable with GCC4

qlge may wildly overrun a debug buffer

Added by Rich Lowe almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2011-11-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

in ql_get_serdes_regs, we write the contents of our registers into a struct ql_mpi_coredump. Unfortunately in two cases we mis-index arrays in the dump structure, and write to array+<physical offset of register>, way out of bounds.

GCC4 notices.

This code is only called in the face of (systemic?) device errors signalled from the board, and is likely very hard to reproduce, even while having hardware, unless a call to ql_8xxx_binary_core_dump is artificially inserted.

Actions #1

Updated by Rich Lowe over 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100
  • Tags deleted (needs-triage)

Resolved in r13619 commit:1ca8a76b1e84

Actions

Also available in: Atom PDF