Project

General

Profile

Actions

Bug #1886

closed

Bug #1450: Illumos should be buildable with GCC4

intel_nb5000 may erroneously decide DIMMs aren't present

Added by Rich Lowe almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
kernel
Start date:
2011-12-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The intel_nb500 code does this

dp->mtr_present = MTR_PRESENT(mtr);

but MTR_PRESENT is

#define    MTR_PRESENT(mtr) \
      ((mtr) & (nb_chipset == INTEL_NB_5400 || nb_chipset == INTEL_NB_5100 ? \
      0x0400 : 0x0100))

Given mtr_present is a byte, this truncates to always being 0.

Actions #1

Updated by Rich Lowe almost 10 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
  • Tags deleted (needs-triage)

Resolved in r13546 commit:6d7e5def82fb

Actions

Also available in: Atom PDF