Project

General

Profile

Bug #1984

libses uses threshold diag page wrong way

Added by Alexander Stetsenko almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Category:
lib - userland libraries
Start date:
2012-01-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
#1

Updated by Alexander Stetsenko almost 9 years ago

type of "data" local variable, which ses2_threshold_ctl_fill returns and uses as paramter to ses2_element_setdef, should be ses2_threshold_impl_t *,
but using "&pip[index]" it threats with pip as with array of ses2_threshold_impl_t (that's bug),
though pip is actually ses2_threshold_out_page_impl_t *.
In order to get pointer to ses2_threshold_impl_t one need to use "&pip->stopi_threasholds[index]".

#2

Updated by Alexander Stetsenko almost 9 years ago

Unfortunately thresholds do not have any flags like "SELECT" for elements.
Elements with non-zero "select" are processed, other ones with zero "select" flag are just ignored.
When THRESHOLD_OUT page is sent it is processed as whole, so if you even change only one threshold all other thresholds are considered to be changed too, and you have to load current values for all thresholds before sending page to ensure they won't change its values.

For example, let assume there are 2 thresholds A & B, and we change parameters of A, in this case B values wil be set to zero, because B threshold contains zeros, and otherwise if we change B, A will be set to 0.

A fix for this should copy thresholds from IN page to OUT, so when OUT page is sent all thresholds are consistent.

#3

Updated by Rich Lowe almost 9 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
  • Tags deleted (needs-triage)

Resolved in r13586 commit:57706b7506c8

Also available in: Atom PDF