Project

General

Profile

Actions
Copy link

Bug #1986

closed

libima misuses gethostname

Added by Rich Lowe over 10 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Dan McDonald
Category:
lib - userland libraries
Start date:
2012-01-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

libima uses gethostname() as if it returns a length, rather than accepts one, in its second argument. We don't get warned about this because we also don't include unistd.h, so nobody notices.

We specify the buffer we have is as long as whatever happened to be on the stack at the time. Bad.

Actions
Copy link
 #1

Updated by Rich Lowe over 10 years ago

Actually, we're also passing the address of dwStrLength, so not "whatever was on the stack" but "the address of the stack".

Actions
Copy link
 #2

Updated by Matt Barden almost 9 years ago

  • Status changed from New to Feedback
  • Assignee set to Dan McDonald
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Rich Lowe almost 9 years ago

  • Status changed from Feedback to Resolved

Resolved in 5d539a8

Actions
Copy link

Also available in: Atom PDF