Project

General

Profile

Bug #224

findunref build shouldn't fail if SCM can't be determined

Added by Rich Lowe about 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
2010-09-17
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

usr/src/tools/findunref/Makefile deals with the possibility SCM_TYPE is "none", but not the possibility that it's "unknown", which in some cases it may be (when using bldenv, for instance).

Either

  1. It should deal with either possibility in the same way
  2. bldenv should use "none" the same as nightly does

History

#1

Updated by Garrett D'Amore almost 9 years ago

  • Category set to tools - gate/build tools
#2

Updated by Rich Lowe over 8 years ago

  • Assignee set to Rich Lowe

The greater root of this is that nightly sets SCM_TYPE="none" in the case of any SCM which it does not understand, whereas bldenv does not.

#3

Updated by Rich Lowe over 8 years ago

  • Status changed from New to In Progress

Actually, this whole thing is bogus. There's utterly no reason to go through any of this pain, and the very idea of Makefile concerning itself with the SCM bothers me greatly in the first place.

The only somewhat valid reason this is the way it is is that it is possible, in theory, is that it may be necessary to pacify checkpaths. It turns out that's never true: any valid entry in the SCM-specific lists is also an entry with a leading wildcard, which checkpaths explicitly ignores. I plan to delete all the SCM specific files and the build junk, and add those entries which actually need to exist to exception_list.common, fixing the subversion entry in the process (I'm not certain why the file existed, but it was clearly never tested).

In doing this, bldenv doesn't even need to know anything about the SCM (as it should be!) and will cease to know about it, and nightly will cease exporting the SCM type to deter anyone else from depending on it.

#4

Updated by Rich Lowe over 8 years ago

  • Status changed from In Progress to Resolved
  • Difficulty set to Medium
  • Tags set to needs-triage

Resolved in r13361 commit:2502776ad797

Also available in: Atom PDF