Bug #2412

Various CPU features aren't intel specific

Added by Rich Lowe about 2 years ago. Updated about 2 years ago.

Status:Resolved Start date:2012-03-16
Priority:Normal Due date:
Assignee:Hans Rosenfeld % Done:

100%

Category:kernel Spent time: -
Target version:-
Difficulty:Medium Tags:

Description

There are a number of CPU features which, in cpuid.c are conditional on Intel being the processor vendor. Several of these (XSAVE/OSXSAVE/AVX and I think SSE3, SSE4, etc.) are actually now present on AMD processors and should be made generic.

History

Updated by Hans Rosenfeld about 2 years ago

  • Category set to kernel
  • Status changed from New to In Progress
  • Assignee set to Hans Rosenfeld
  • % Done changed from 0 to 100

Updated by Richard PALO about 2 years ago

Hans Rosenfeld wrote:

Webrev: http://cr.illumos.org/view/hxb6kk39/illumos-2412-webrev/

Today, running a 6100 on oi_151a2 I see, for example, sse3 already ...

ssh <machine>...
Last login: Thu Mar 29 19:26:42 2012 from 192.168.0.17
OpenIndiana (powered by illumos)    SunOS 5.11    oi_151a2    January 2012
$ smbios -t SMB_TYPE_PROCESSOR
ID    SIZE TYPE
4     187  SMB_TYPE_PROCESSOR (processor)

  Manufacturer: AMD              
  Version: AMD Opteron(tm) Processor 6128                      
  Serial Number: To Be Filled By O.E.M.
  Asset Tag: To Be Filled By O.E.M.
  Location Tag: CPU 1
  Part Number: To Be Filled By O.E.M.

  Family: 132 (Opteron)
  CPUID: 0x178bfbff00100f91
  Type: 3 (central processor)
  Socket Upgrade: 26
  Socket Status: Populated
  Processor Status: 1 (enabled)
  Supported Voltages: 1.2V
  External Clock Speed: Unknown
  Maximum Speed: 2000MHz
  Current Speed: 2000MHz
  L1 Cache: 5
  L2 Cache: 6
  L3 Cache: 7

$ isainfo -v
64-bit amd64 applications
        amd_svm amd_lzcnt popcnt amd_sse4a tscp ahf cx16 sse3 sse2 sse fxsr 
        amd_3dnowx amd_3dnow amd_mmx mmx cmov amd_sysc cx8 tsc fpu 
32-bit i386 applications
        amd_svm amd_lzcnt popcnt amd_sse4a tscp ahf cx16 sse3 sse2 sse fxsr 
        amd_3dnowx amd_3dnow amd_mmx mmx cmov amd_sysc cx8 tsc fpu 

perhaps you mean SSSE3, SSE4.x and co (judging by your patch)...
integration of this would be greatly appreciated!

Updated by Albert Lee about 2 years ago

  • Status changed from In Progress to Resolved
  • Tags deleted (needs-triage)

Fixed in:
changeset: 13655:0461a7e94e53
tag: tip
user: Hans Rosenfeld <>
date: Sun Apr 01 21:19:32 2012 +0200
files: usr/src/uts/i86pc/os/cpuid.c
description:
2412 Various CPU features aren't intel specific
Reviewed by: Richard Lowe <>
Reviewed by: Robert Mustacchi <>
Approved by: Albert Lee <>

Also available in: Atom PDF