Project

General

Profile

Bug #2426

Bug #1450: Illumos should be buildable with GCC4

wanboot openssl needs to not call cast function pointers

Added by Rich Lowe over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Start date:
2012-03-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Casting of function pointers is undefined.

GCC feel strongly about this, apparently, to the degree that it 4.2 they emit a trap in place of such a call to guarantee that you crash if you do it.

OpenSSL does it.

We need to integrate the OpenSSL patches from upstream to the wanboot openssl (I'm referring to it that way, because it is the only thing the openssl in illumos is used for, it is in illumos because of the patches to make it usable in a SPARC standalone binary).

I propose to apply the changes from upstream, in this changeset: http://cvs.openssl.org/chngview?cn=16526 which are directly relevant and not lint fixes (that is, not the void casts, not the fixes to code we do not compile).

History

#1

Updated by Igor Kozhukhov over 8 years ago

can we use static libssl.a & libcrypto.a from userland build ?
I have temporary fixed illumos-build on sparc for libssl-1.0 with static libs for wanboot.
I have used + libc-pic.a + some stubs for ldopen/ldclose.
if you are interested in this I can provide my patch.

#2

Updated by Rich Lowe over 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 60 to 100

Resolved in r13645 commit:1cef92b663d9

Also available in: Atom PDF