Project

General

Profile

Actions

Bug #2426

closed

Bug #1450: Illumos should be buildable with GCC4

wanboot openssl needs to not call cast function pointers

Added by Rich Lowe almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Start date:
2012-03-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Casting of function pointers is undefined.

GCC feel strongly about this, apparently, to the degree that it 4.2 they emit a trap in place of such a call to guarantee that you crash if you do it.

OpenSSL does it.

We need to integrate the OpenSSL patches from upstream to the wanboot openssl (I'm referring to it that way, because it is the only thing the openssl in illumos is used for, it is in illumos because of the patches to make it usable in a SPARC standalone binary).

I propose to apply the changes from upstream, in this changeset: http://cvs.openssl.org/chngview?cn=16526 which are directly relevant and not lint fixes (that is, not the void casts, not the fixes to code we do not compile).

Actions

Also available in: Atom PDF