Project

General

Profile

Bug #2445

savecore fails with dump archive but return EXIT_OK

Added by Alexander Eremin over 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
cmd - userland programs
Start date:
2012-03-23
Due date:
2012-07-24
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

  1. savecore -vf /var/crash/myshost/vmdump.3
    savecore: bad magic number 3a650c00
  2. echo $?
    0

And looking through read_dumphdr():

  if (dumphdr.dump_magic != DUMP_MAGIC)
        logprint(SC_SL_NONE | SC_EXIT_OK, "bad magic number %x",
             dumphdr.dump_magic);

it seems other cases like version mismatch and others also use SC_EXIT_OK. Probably here should be SC_EXIT_PEND instead of EXIT_OK.

History

#1

Updated by Alexander Eremin about 8 years ago

  • Due date set to 2012-07-24
  • Status changed from New to Pending RTI
  • Assignee set to Alexander Eremin
  • % Done changed from 0 to 100
#2

Updated by Rich Lowe about 8 years ago

Resolved in r13760 commit:527f645bd884

#3

Updated by Rich Lowe about 8 years ago

  • Status changed from Pending RTI to Resolved

Also available in: Atom PDF