Project

General

Profile

Feature #2451

beadm umount should report if there is nothing to unmount

Added by Jim Klimov over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
cmd - userland programs
Start date:
2012-03-24
Due date:
% Done:

50%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

Currently, "beadm umount" reports about successful unmounting of the ABE, even if it was already unmounted. While this report is pedantically correct, a warning for an interactive user would be nice - he could have been doing some work on the ABE which was not in fact mounted at that time, so he could have made some mistakes and can begin recovery until it's too late ;)

Also, there is such a report on attempted subsequent mounts of the BE, so it would make sense to match that:

root@openindiana:/# beadm mount oi_151b /a
Mounted successfully on: '/a'
root@openindiana:/# beadm mount oi_151b /a
oi_151b is already mounted.
Please unmount the BE before mounting it again.

root@openindiana:/# beadm umount oi_151b
Unmounted successfully
root@openindiana:/# beadm umount oi_151b
Unmounted successfully
root@openindiana:/# beadm umount oi_151b
Unmounted successfully

History

#1

Updated by Alexander Eremin over 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Alexander Eremin
  • % Done changed from 0 to 50
#2

Updated by Gordon Ross over 8 years ago

  • Status changed from In Progress to Resolved
changeset:   13663:a64c8d17c8f4
tag:         tip
user:        Alexander Eremin <a.eremin@nexenta.com>
date:        Mon Apr 09 13:29:54 2012 +0400
description:
    2451 beadm umount should report if there is nothing to unmount
    2450 beadm umount should support mountpoint name
    Reviewed by: Dan Kruchinin <dkruchinin@acm.org>
    Reviewed by: Michael Schuster <michaelsprivate@gmail.com>
    Reviewed by: Gary Mills <gary_mills@fastmail.fm>
    Approved by: Gordon Ross <gwr@nexenta.com>

Also available in: Atom PDF