Project

General

Profile

Actions

Bug #2565

closed

dtrace tests could stop fighting the compiler

Added by Rich Lowe over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
DTrace
Start date:
2012-03-30
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Rather than entering an arms race with the optimizers of various compilers, which due to the small and contained nature of the C code in the dtrace tests tend to have a field day, it is perhaps a better idea to just cease optimizing them.

Most of the tests care solely about ABI-related things (arguments, call/return, etc) which are actually more likely to break in an optimized potted test (and, in fact, do). The tests which care about the actual instruction stream are limited to tests with implement every insn in a given small program, one to test doing so with gcc-compiled executables, the other to test the same when using the FPU. Neither of these is affected in purpose by the optimizer.

That said, someone with more expertise should have the opportunity to say that this is foolish, and we should do whatever is necessary to win out over the optimizer while retaining the optimization level.

Actions #1

Updated by Rich Lowe over 9 years ago

  • Status changed from New to Resolved
  • % Done changed from 60 to 100

Resolved in r13667 commit:042db6341598

Actions

Also available in: Atom PDF