Project

General

Profile

Bug #2724

snoop contains few problems with accessing uninitialized data

Added by Milan Jurik over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2012-05-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Code analysis from Studio 12.3 shows several problems in snoop code:

cap_open_read() does not initialized device_mac_type

compare_value_zone() was mismerged during previous putback

ipaddr_match() and pf_ipaddr_match() could continue even if hp is not assigned

print_ripso() checks if ripso_class is detected but the test is incorrect.

print_rpc_gss_init_arg() and print_rpc_gss_init_res() should print from pos = 0


Files

snoop-analysis.patch (8.59 KB) snoop-analysis.patch suggested fix Milan Jurik, 2012-06-05 04:42 PM

Also available in: Atom PDF