consistent use of #pragma align would please GCC
Right now, we patch GCC to accept #pragma align after a declaration, as well as before. It's not a big patch, and it makes it more consistent with studio but, given that there's only really about 4 places in which we actually do this, and all of them are trivial to fix, it's easy enough to fix our code.
Updated by Richard PALO over 7 years ago
Actually, from what I see in the gate today, there is only one file actually needing therapy:
The attached patch should deal with that.
(the initial file list to check wasn't even half a page!)
Updated by Rich Lowe over 7 years ago
So, I should have updated this bug and didn't.
The reason I never fixed this is that it turned out that while studio accepted a "late" pragma align, it didn't actually do anything with it. My notes say I intended to double check whether we wanted the behaviour the code appeared to specify, or the behaviour the compiler actually gave us.
I appear to have done neither.
I think, on balance, that what Richard has done is the right thing to do. I just wanted to make sure I noted this in the bug (as I should have done at the time).
Updated by Electric Monk over 7 years ago
- Status changed from In Progress to Closed
- % Done changed from 50 to 100
commit 90b1de135fcfa7ce4adc9138a885aa94bbcef04f Author: Richard PALO <richard@NetBSD.org> Date: 2014-12-01T16:29:56.000Z 2732 consistent use of #pragma align would please GCC Reviewed by: Richard Lowe <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>