Project

General

Profile

Actions

Bug #2945

closed

mdb needs to export _mdb_ks_pageoffset

Added by Keith Wesolowski over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
cmd - userland programs
Start date:
2012-06-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Modules are supposed to use mdb_param.h instead of sys/param.h. However, anyone who does so and then references a macro that uses PAGEOFFSET will fail to link. KVM's dmod is known to do this.


Files

2945.diff (1.15 KB) 2945.diff Keith Wesolowski, 2012-07-15 09:21 PM
Actions #1

Updated by Rich Lowe over 9 years ago

Consider me having reviewed this via the equivalent change in illumos-joyent and file your RTI so I can push it? please? pretty please?

Actions #2

Updated by Keith Wesolowski over 9 years ago

illumos-gate has too many dependencies to build on anything I have ready access to, so testing this to a level sufficient to file an RTI is impractical. The change is shipping to customers and is known to work in smartos-live; if someone wants to pick it up and integrate it, feel free.

Actions #3

Updated by Igor Kozhukhov over 9 years ago

I have tested it with my change set : https://bitbucket.org/dilos/dilos-illumos-gate/changeset/47dd5d1c0f0e
I have tested it with latest joyent-illumos-kvm - build well with removed gcc flags form Makefile '-fno-dwarf2-indirect-strings'

Actions #4

Updated by Rich Lowe over 9 years ago

  • Status changed from New to Resolved
  • % Done changed from 90 to 100

Resolved in r13752 commit:9f5f6c52ba19

Actions

Also available in: Atom PDF