Project

General

Profile

Actions
Copy link

Bug #2982

closed

nfs3: cleanup debug code at nfs3_srv.c

Added by Vitaliy Gusev over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Vitaliy Gusev
Category:
nfs - NFS server and client
Start date:
2012-07-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

nfs3_srv.c has some vain code that makes difficult to do
modifying or improving.


          #ifdef DEBUG
           int rfs3_do_pre_op_attr = 1;
           int rfs3_do_post_op_attr = 1;
           int rfs3_do_post_op_fh3 = 1;
          #endif
          ...

          #ifdef DEBUG
      if (rfs3_do_pre_op_attr)
                bvap = &bva;
          #else
       bvap = &bva;
          #endif
Actions
Copy link
 #1

Updated by Vitaliy Gusev over 9 years ago

Non-debug kernel doesn't have those variables, so they can be removed.

Actions
Copy link
 #2

Updated by Albert Lee about 9 years ago

I think the justification here is that the code was used for testing a specific scenario during implementation and isn't generally useful to any future maintainers.

Actions
Copy link
 #3

Updated by Vitaliy Gusev about 9 years ago

For non-debug compiled:

~# elfcmp before/nfssrv after/nfssrv

Section .compcom differs

tested it by filebench + iozone.

Actions
Copy link
 #4

Updated by Yuri Pankov about 9 years ago

  • Category set to nfs - NFS server and client
  • Status changed from New to Resolved
  • % Done changed from 0 to 100
  • Tags deleted (needs-triage)

Resolved in 13787:b4edc3a4e855.

Actions
Copy link

Also available in: Atom PDF