Bug #2989: LOGNAME_MAX should be increased to 32 - illumos gate - illumos

Actions

Copy link

Bug #2989

closed

LOGNAME_MAX should be increased to 32

Added by Albert Lee about 11 years ago. Updated almost 10 years ago.

Status:

Resolved

Priority:

Low

Assignee:

Gary Mills

Category:

cmd - userland programs

Start date:

2012-07-11

Due date:

% Done:

100%

Estimated time:

Difficulty:

Medium

Tags:

Gerrit CR:

External Bug:

Description

The current username length limit of 8 is extremely restrictive and will hopefully change in the future. To ease a future transition, applications using the LOGNAME_MAX constant to determine buffer sizes should be migrated to the dynamic value returned by sysconf(_SC_LOGIN_NAME_MAX). A quick search shows there are still several such consumers in ON.

(See discussion on long user names for PSARC/2010/184 here: http://arc.opensolaris.org/caselog/PSARC/2010/184/mail or here http://mail.opensolaris.org/pipermail/opensolaris-arc/2010-May/thread.html#21475 )

Files

Download all files

tests.txt (16.6 KB) tests.txt	All Tests	Gary Mills, 2013-05-31 07:35 PM
2989-5.patch.Z (44.5 KB) 2989-5.patch.Z		Gary Mills, 2013-08-11 12:42 PM

Actions

Copy link

Updated by Gary Mills over 10 years ago

Assignee set to Gary Mills
% Done changed from 0 to 80

Many source files in illumos employ LOGNAME_MAX to size buffers that are located on the stack. Since login names are limited to 32 characters by the utmpx structure, I decided that the changes would be simplified by introducing two new symbols into the limits.h header:

#define    LOGNAME_MAX_ILLUMOS    32    /* max # of characters in an */
                    /* illumos login name */
#define    LOGIN_NAME_MAX    (LOGNAME_MAX_ILLUMOS + 1)    /* max buffer size */

Many of the commands affected display output from either the process table or the utmpx/wtmpx files. In modifying the source files, I followed these principles:

No change in output format if login names are limited to 8 characters
Display long names in full wherever possible
Retain 80-column format for curses output
Add a truncation indicator when long names are truncated

Actions

Copy link

Updated by Gary Mills over 10 years ago

I've now dropped the LOGNAME_MAX_ILLUMOS symbol and instead increased LOGNAME_MAX from 8 to 32. This change means that most applications can just be recompiled without need for a source change. Other changes are intended to accomodate legacy applications. I've added a `-W' flag to `prstat' and `ps' which forces truncation of long login names. Like `prstat', the `ps' command now has a trailing asterisk to indicate that a long name has been truncated. I've also added an adjustable action so that `useradd' can issue a warning or an error when the login name exceeds the legacy value of 8 characters. Finally, I've created a preload library for getlogin(3C) that will truncate long login names. This intended for old executables that cannot handle longer names.

Actions

Copy link

Updated by Gary Mills over 10 years ago

File tests.txt tests.txt added
% Done changed from 80 to 90

I've made a few more changes in the 4th revision. First of all, there are two versions of the getlogin functions. These are selected by the redefine_extname pragma in unistd.h . Old executables get the ones that truncate login names to 8 characters. Newly-built executables get the versions that return full 32-character login names.
The getlogin8.so.1 preload library has been removed, as it's no longer needed. A new preload library, getloginx.so.1, acts as a shim so that old executables can call getlogin() but get the full 32-character login name.
There's a new symbol, USE_LEGACY_LOGNAME, that does the opposite, permitting new executables to be built that get versions of the getlogin functions that truncate login names to 8 characters.
Man pages are updated to describe these changed features.
I've attached a file, tests.txt, that contains results of all of the tests that I've performed to verify that long login names actually worked as intended.

Actions

Copy link

Updated by Andrew Stormont over 10 years ago

Are you saying that _SC_LOGIN_NAME_MAX can never be more than 32 characters long because that's the max supported by utmpx? If that's true is _SC_LOGIN_NAME_MAX enforcing this?

Actions

Copy link

Updated by Gary Mills over 10 years ago

Yes, that's correct. It's a result of the changes to sysconf.c and limits.h . With the changes, the value of LOGNAME_MAX is defined to be 32. See the webrev at:

    http://cr.illumos.org/~webrev/jgmills/2989-4/

for details.

Actions

Copy link

Updated by Gary Mills about 10 years ago

File 2989-5.patch.Z 2989-5.patch.Z added

I've attached a git-style patch named 2989-5.patch.Z to this bug report. This patch is built against illumos-gate from 7 August 2013. I only had to relocate two copyright lines to build it.

Actions

Copy link