Project

General

Profile

Feature #3006

VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero

Added by Madhav Suresh about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
kernel
Start date:
2012-07-17
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
backout

Description

VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero. In addition, libzpool has duplicated assertion code, however with the implementation of assfail in libzpool, it is possible to include <sys/debug.h> in zfs_context.h

Proposed feature is to add VERIFY0, ASSERT0 as a shortcut to this.


Related issues

Related to illumos gate - Bug #3046: crash on boot in zfs_rmnodeResolved2012-08-01

Actions

History

#1

Updated by Madhav Suresh about 7 years ago

  • % Done changed from 0 to 100
#2

Updated by Eric Schrock about 7 years ago

  • Status changed from New to Resolved

changeset: 13764:38b4aca480b3
tag: tip
user: Madhav Suresh <>
date: Tue Jul 31 06:38:31 2012 -0700

description:
3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
Reviewed by: Matt Ahrens <>
Reviewed by: George Wilson <>
Approved by: Garrett D'Amore <>

#3

Updated by Rich Lowe about 7 years ago

  • Status changed from Resolved to New
  • % Done changed from 100 to 0
  • Tags changed from needs-triage to backout

Backed out in 13765:9410cf539b11

#4

Updated by Eric Schrock about 7 years ago

  • Status changed from New to Resolved

changeset: 13805:e3a9ae14a119
tag: tip
user: Madhav Suresh <>
date: Fri Sep 07 07:19:55 2012 -0700

description:
3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
Reviewed by Matt Ahrens <>
Reviewed by George Wilson <>
Approved by Eric Schrock <>

Also available in: Atom PDF