Feature #3006
closedVERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
0%
Description
VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero. In addition, libzpool has duplicated assertion code, however with the implementation of assfail in libzpool, it is possible to include <sys/debug.h> in zfs_context.h
Proposed feature is to add VERIFY0, ASSERT0 as a shortcut to this.
Related issues
Updated by Eric Schrock almost 11 years ago
- Status changed from New to Resolved
changeset: 13764:38b4aca480b3
tag: tip
user: Madhav Suresh <madhav.suresh@delphix.com>
date: Tue Jul 31 06:38:31 2012 -0700
description:
3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
Reviewed by: Matt Ahrens <matthew.ahrens@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Approved by: Garrett D'Amore <garrett@damore.org>
Updated by Rich Lowe almost 11 years ago
- Status changed from Resolved to New
- % Done changed from 100 to 0
- Tags changed from needs-triage to backout
Backed out in 13765:9410cf539b11
Updated by Eric Schrock over 10 years ago
- Status changed from New to Resolved
changeset: 13805:e3a9ae14a119
tag: tip
user: Madhav Suresh <madhav.suresh@delphix.com>
date: Fri Sep 07 07:19:55 2012 -0700
description:
3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
Reviewed by Matt Ahrens <matthew.ahrens@delphix.com>
Reviewed by George Wilson <george.wilson@delphix.com>
Approved by Eric Schrock <eric.schrock@delphix.com>