Project

General

Profile

Bug #3059

cmd/tcpd/* files should have correct functions prototypes

Added by Igor Kozhukhov about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
cmd - userland programs
Start date:
2012-08-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

They are files have no correct prototypes of functions:
cmd/tcpd/fakelog.c
have:
openlog(name, logopt, facility)
should be:
void openlog(name, logopt, facility)

have:
vsyslog(severity, fmt, ap)
should be:
void vsyslog(severity, fmt, ap)

have:
VARARGS
should be :
void VARARGS

have:
closelog()
should be:
void closelog()

cmd/tcpd/safe_finger.c
have:
main(argc, argv)
should be:
int main(argc, argv)

cmd/tcpd/tcpd.c
have:
main(argc, argv)
should be:
int main(argc, argv)

cmd/tcpd/try-from.c:
have:
main(argc, argv)
should be:
int main(argc, argv)

gcc46 compiler have warning about incorrect prototypes.

History

#1

Updated by Igor Kozhukhov about 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Igor Kozhukhov
  • % Done changed from 60 to 100

I can't change state "to RTI"

#2

Updated by Igor Kozhukhov about 8 years ago

  • Status changed from In Progress to Pending RTI
#3

Updated by Eric Schrock about 8 years ago

  • Status changed from Pending RTI to Resolved

changeset: 13770:f6f7025c7a4d
tag: tip
user: Igor Kozhukhov <>
date: Sun Aug 12 07:51:54 2012 -0700

description:
3059 cmd/tcpd/* files should have correct functions prototypes
Reviewed by: Garrett D'Amore <>
Reviewed by: Gary Mills <>
Approved by: Eric Schrock <>

Also available in: Atom PDF