Bug #30
closed
Added by Garrett D'Amore almost 13 years ago.
Updated over 6 years ago.
Description
We need a working iconv implementation. The GNU version may be usable, but note that we already have about half (or more!) of the needed in our libc and supporting utilities. I think a new/separate implementation of iconv may be better
Files
- Project changed from site to illumos gate
Garrett: Should I assign the bug to me ? I have prototype code floating around...
- Assignee set to Roland Mainz
- % Done changed from 0 to 20
Taking bug myself...
... first I do /usr/bin/iconv ... but we need a 2nd bug to cover the individual iconv conversion modules.
Here is some code to get someone started.
Still quite a bit todo though.
The hard part will be handling charmap files. For that,
see the code in $SRC/cmd/localedef
- Difficulty set to Medium
- Tags set to needs-triage
- Assignee deleted (
Roland Mainz)
- Tags deleted (
needs-triage)
I think that the code Gordon attached, above, may not be his most up-to-date code. He has some code that I'd actually reviewed and I think been happy with, but he hadn't really tested. You may want to sync up with him, at least to find the state of things?
There's some reasonably complete (and somewhat tested) code here:
http://yalms.org/cr/illumos-30/
Reviewers recommended that it should have some tests written to
show that it works as well as the closed version. Sorry but I don't
have time to work on those tests. Volunteers?
I wrote similar code the last 2 days :( :( :( Redmine dont even send me the new comments...
http://cr.illumos.org/~webrev/0xffea/iconv-rewrite-02/
I rewrote the shell script in C maybe this is of use. WIDTH and WIDTH_DEFAULT are missing, but they are also missing in localedef(1)
WIDTH
<A> 1
END WIDTH
If i recover from my disappointment, i maybe can take a look.
- Status changed from New to Closed
- % Done changed from 20 to 100
git commit 48edc7cf07b5dccc3ad84bf2dafe4150bd666d60
commit 48edc7cf07b5dccc3ad84bf2dafe4150bd666d60
Author: Gordon Ross <gwr@nexenta.com>
Date: 2016-10-24T18:17:22.000Z
30 Need iconv
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Approved by: Dan McDonald <danmcd@omniti.com>
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by