Remove any existing references to utmp, use utmpx instead
usr/src/cmd/w/w.c still references the
nonuser macro from utmp.h (utmpx.h's is
nonuserx) and possibly other legacy utmp definitions.
Updated by Sachidananda Urs over 7 years ago
Excerpt from Marcel's review comments:
While on this, I suggest to do similar fixes here too:
and maybe here as well:
In addition, this is in the getutxent(3c) man page:
For records of type USER_PROCESS, the nonuser() and nonuserx() macros
use the value of the ut_exit.e_exit member to mark utmpx entries as
real logins (as opposed to multiple xterms started by the same user on
a window system). This allows the system utilities that display users
to obtain an accurate indication of the number of actual users, while
still permitting each pty to have a utmpx record (as most applications
expect.). The NONROOT_USER macro defines the value that login places in
the ut_exit.e_exit member.
and I see two problems there:
1) the nonuser() macro shouldn't be mentioned here.
2) we should change NONROOT_USER to NONROOT_USRX. (Note: NONROOT_USER is a
typo in any case, the correct name is NONROOT_USR for the utmp entries).
I'd really appreciate to see all of that fixed.
Updated by Electric Monk over 7 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 1eabc4bec6d2a5ad71f6a1f0c019af5438d8b1bf Author: Sachidananda Urs <email@example.com> Date: 2014-12-01T16:42:16.000Z 3124 Remove any existing references to utmp, use utmpx instead Reviewed by: Josef 'Jeff' Sipek <firstname.lastname@example.org> Reviewed by: Marcel Telka <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>