Project

General

Profile

Actions

Bug #3133

closed

nfs4: remove static for nfs4_max_xxx

Added by Daniil Lunev almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
nfs - NFS server and client
Start date:
2012-08-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Being static defined, these variables can not be changed with mdb etc. Also, possibly some future patches will be based on it.

Actions #1

Updated by Rich Lowe almost 9 years ago

Actually, static globals are perfectly visible to mdb.

Actions #2

Updated by Daniil Lunev almost 9 years ago

Actually, it's not a problem of visibility.

Code in nfs4_common.c:
static uint_t nfs4_max_transfer_size = 32 * 1024;
static uint_t nfs4_max_transfer_size_cots = 1024 * 1024;
static uint_t nfs4_max_transfer_size_rdma = 1024 * 1024;
int
nfs4tsize(void) {
/* * For the moment, just return nfs4_max_transfer_size until we * can query the appropriate transport.
*/
return (nfs4_max_transfer_size);
}

::dis nfs4tsize
nfs4tsize: pushq %rbp
nfs4tsize+1: movq %rsp, %rbp
nfs4tsize+4: movl $0x8000, %eax
nfs4tsize+9: leave
nfs4tsize+0xa: ret

As you can see, nfs4_max_transfer_size value hard coded and can't be changed at all.

Actions #3

Updated by Rich Lowe almost 9 years ago

  • Category set to nfs - NFS server and client
  • Status changed from Feedback to Resolved
  • Assignee set to Vitaliy Gusev
  • Tags deleted (needs-triage)

Resolved in r13799 commit:0b5d8823b20a

Actions

Also available in: Atom PDF