Bug #3133
closednfs4: remove static for nfs4_max_xxx
100%
Description
Being static defined, these variables can not be changed with mdb etc. Also, possibly some future patches will be based on it.
Updated by Rich Lowe about 11 years ago
Actually, static globals are perfectly visible to mdb.
Updated by Daniil Lunev about 11 years ago
Actually, it's not a problem of visibility.
Code in nfs4_common.c:
static uint_t nfs4_max_transfer_size = 32 * 1024;
static uint_t nfs4_max_transfer_size_cots = 1024 * 1024;
static uint_t nfs4_max_transfer_size_rdma = 1024 * 1024;
int
nfs4tsize(void)
{
/*
* For the moment, just return nfs4_max_transfer_size until we
* can query the appropriate transport.
*/
return (nfs4_max_transfer_size);
}
::dis nfs4tsize
nfs4tsize: pushq %rbp
nfs4tsize+1: movq %rsp, %rbp
nfs4tsize+4: movl $0x8000, %eax
nfs4tsize+9: leave
nfs4tsize+0xa: ret
As you can see, nfs4_max_transfer_size value hard coded and can't be changed at all.
Updated by Rich Lowe about 11 years ago
- Category set to nfs - NFS server and client
- Status changed from Feedback to Resolved
- Assignee set to Vitaliy Gusev
- Tags deleted (
needs-triage)
Resolved in r13799 commit:0b5d8823b20a