Project

General

Profile

Bug #3155

nfs: fs_location being asked but not setted return error

Added by Daniil Lunev about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
nfs - NFS server and client
Start date:
2012-09-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

fs_location can be used for replication issues. So, if it's not setted, return should be returned.

#1

Updated by Daniil Lunev about 8 years ago

Oh, sorry, it seems like I got a big mistake, when I typed it. :)
FS_LOCATION attribute is the attribute that describe new file's location if file was moved (to another server, or somewhere else). It's a migrating case. Also, there is another case of using FS_LOCATION - replication. We did not moved file, but just copy it to another place and client to know it. Then, we can add this kind of attribute to a file to describe that it has a copy somewhere else. Client may want to know, if there are any copies of the file. Then it makes GETATTR request to get FS_LOCATION. But currently, if file has not this attribute setted, server will return error. It's wrong because we didn't face an error. RFC is ambiguous about what server should return in this case. One possible way is just clearing FS_LOCATION bit in response and returning nothing, second way is returning zero-filled fs_location structure. As I think, the correct way is the second.

#2

Updated by Rich Lowe about 8 years ago

  • Status changed from Feedback to Resolved

Resolved in r13822 commit:d13dbeb3e979

Also available in: Atom PDF