Project

General

Profile

Bug #3193

mdb save-args matching should only consider insns which have executed

Added by Rich Lowe about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2012-09-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

At present, we search for the save-args prologue within 80 bytes of the start of the function, regardless of the position of %pc. This leads us to possibly match a function, and return its "arguments" when the actual saving of arguments has not yet occurred.

We should limit our search to the current function prior to the program counter.

This may backfire if the function were to have a backward branch or jump from after argument saving to a place before it, but this is both unlikely and, were it to happen, grossly damaging to the whole concept of the save area in general.

#1

Updated by Rich Lowe about 8 years ago

  • Status changed from New to In Progress
#2

Updated by Rich Lowe about 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

Resolved in 2d4be7a

Also available in: Atom PDF