Project

General

Profile

Bug #32

we need cr.illumos.org to support posting webrevs

Added by Garrett D'Amore over 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Low
Assignee:
Captain Administrator
Target version:
-
Start date:
2010-08-07
Due date:
% Done:

100%

Estimated time:
Difficulty:
Tags:

Description

We need a cr.illumos.org facility similar to cr.opensolaris.org.

#1

Updated by Andre van Eyssen over 10 years ago

  • Status changed from New to In Progress
  • Assignee set to Andre van Eyssen
  • % Done changed from 0 to 30

After seeing the dark soul of python, ReviewBoard is installed and the keys have been handed to Garrett to look at configuration.

#2

Updated by Andre van Eyssen over 10 years ago

  • Assignee changed from Andre van Eyssen to Garrett D'Amore

Assigning to Garrett for config tasks ...

#3

Updated by Garrett D'Amore over 10 years ago

  • Priority changed from Normal to Low

So there seem to be many problems with review board. It barfs on reasonable hg diffs, doesn't take updated difs generated via hg pdiff -g, and generally seems to not be terribly useful.

Rich Lowe has started looking at these problems, so I'm going to assign the ticket to him (he has sufficient python-fu to at least try to work out the bugs). Ultimately, it may prove that we need to abandon review board and come up with an ssh based mechanism. I know Rich says he'd prefer anything over webrev because its apparently quite fragile.

So nobody freaks out, I'm also dropping the priority of this to Low. We need a solution at some point, but it can wait a few weeks if need be.

#4

Updated by Garrett D'Amore over 10 years ago

  • Assignee changed from Garrett D'Amore to Rich Lowe
#5

Updated by Captain Administrator over 10 years ago

How does this solution sound?

cr.illumos.org will have a file upload button. You can upload a zipped file containing the file generated by webrev, and on my end, I confirm this (by looking at filenames), and extract and expose it in serial folders. So we can have something like cr.illumos.org/001/ and cr.illumos.org/002/ .. etc. I think there are some simple php scripts that would do this, and I'll add the additional logic to unzip and export. Much better than worrying about setting up rsync/ssh and public keys, etc.

~Anil

#6

Updated by Garrett D'Amore over 10 years ago

This seems like a good solution. It would be better if we could make hooks work with this using webrev. And we need a way to clean up the old reviews, because they can suck up a lot of space.

#7

Updated by Captain Administrator over 10 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Rich Lowe to Captain Administrator
  • % Done changed from 30 to 100

http://cr.illumos.org is implemented via a simple uploader. The script /tank/cr.freeon.org/extract.sh takes care of extracting and publishing.

~Anil

#8

Updated by Captain Administrator over 10 years ago

Come to think of it I could add also add a line to send a mail to developer@ list everytime a review is uploaded. what do others think of this?

~Anil

#9

Updated by Jeppe Toustrup over 10 years ago

Considering that you can't update an uploaded webrev, I don't like that idea. It could lead to a lot of mails on the list, for every little correction people may do to their webrev. I rather think an e-mail should be sent to the developer list when a new bug is created in the issue tracker then.

#10

Updated by Garrett D'Amore over 10 years ago

Agreed, we need a way to be able to update existing webrevs.

This deserves some more thought and work.

#11

Updated by Captain Administrator over 10 years ago

  • Status changed from Resolved to Feedback

Garrett D'Amore wrote:

Agreed, we need a way to be able to update existing webrevs.

This deserves some more thought and work.

Ok.

I'll be doing the following:

  • Add support for tar.gz.
  • Allow a user definable patch name and password when uploading. He can later provide the same name, and the password to update the webrev.

Any other RFEs?

~Anil

#12

Updated by Garrett D'Amore about 10 years ago

  • Status changed from Feedback to Closed

Closing this as a dup of 226. The current implementation == fail. See 226 for more info.

Also available in: Atom PDF