Project

General

Profile

Actions
Copy link

Bug #3253

open

tsol headers mess

Added by Igor Pashev about 9 years ago. Updated about 9 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2012-10-03
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Function is_system_labeled() is defined in libc, but its prototype is in header from libtsol
(illumos-gate/usr/src/lib/libtsol/common/label.h)

illumos-gate/usr/src/lib/libc/port/gen/ucred.c includes tsol/label.h, but only for is_system_labeled() , which is in libc.
All other definitions are in kernel header sys/tsol/label.h.

So, tsol/label.h should not be a part of libtsol, and should only provide functions form libc.

For libtsol itself there should be a separated header (http://docs.oracle.com/cd/E19082-01/819-2242/libtsol-3lib/index.html)

Actions
Copy link
 #1

Updated by Igor Pashev about 9 years ago

Same for usr/src/head/zone.h - it really needs only sys/tsol/label.h.

Actions
Copy link
 #2

Updated by Igor Pashev about 9 years ago

Also illumos-gate/usr/src/lib/libnsl/rpc/svc_generic.c and
illumos-gate/usr/src/lib/libnsl/rpc/ti_opts.c
need only is_system_labeled() from libc

Actions
Copy link

Also available in: Atom PDF