Project

General

Profile

Actions
Copy link

Bug #3363

closed

Mark non-returning functions in ctftools

Added by Erik Cederstrand almost 11 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2012-11-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

This trivial patch marks the two non-returning function definitions terminate() and aborterr() in ctftools.h as non-returning. This helps Clang Static Analyzer.

The attachment is against FreeBSD source code.

Files

ctf.txt (761 Bytes) ctf.txt Erik Cederstrand, 2012-11-14 09:16 PM
Actions
Copy link
 #1

Updated by Erik Cederstrand almost 10 years ago

  • Status changed from New to Feedback

One year anniversary :-) Any chance to get someone to accept or close this bug? Thanks!

Actions
Copy link
 #2

Updated by Erik Cederstrand almost 9 years ago

Two year anniversary :-) Any chance to get someone to accept or close this two-liner patch? Thanks!

Actions
Copy link
 #3

Updated by Rich Lowe almost 9 years ago

It'll need to use NORETURN rather than using __attribute directly, I think. Otherwise I can get this done I think.

What's the email address I should use for the commit authorship?

Actions
Copy link
 #4

Updated by Erik Cederstrand almost 9 years ago

Ok, looks good. My email address is

Actions
Copy link
 #5

Updated by Electric Monk almost 9 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

git commit a6bde1a23b60f140c7ed78df979c2e22b1ed9b2c

commit  a6bde1a23b60f140c7ed78df979c2e22b1ed9b2c
Author: Erik Cederstrand <erik@cederstrand.dk>
Date:   2014-11-12T19:53:00.000Z

    3363 Mark non-returning functions in ctftools
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Approved by: Albert Lee <trisk@omniti.com>

Actions
Copy link

Also available in: Atom PDF