Actions
Bug #3379
closed
Duplicate assignment in uts/common/cpr/cpr_stat.c
Start date:
2012-11-23
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:
Description
https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/common/cpr/cpr_stat.c#L74
https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/common/cpr/cpr_stat.c#L76
cep->ce_ntests |= CE_START_MASK;
cep->ce_sec.stime = cep->ce_sec.etime = tv.tv_sec;
cep->ce_sec.ltime = cep->ce_sec.ltime = 0; /* <<=== HERE === */
cep->ce_msec.stime = cep->ce_msec.etime = tv.tv_nsec / 100000000;
cep->ce_msec.ltime = cep->ce_msec.ltime = 0; /* <<=== HERE === */
Updated by Gary Mills over 9 years ago
- Status changed from New to Feedback
Yes, this seems to be an error. The mtime member is used but never initialized.
Updated by Gary Mills over 9 years ago
I now understand that the mtime member is only set to zero when the cpr driver is loaded. It should not be set in the cpr_stat_event_start() function.
Updated by Gary Mills over 9 years ago
- Status changed from Feedback to In Progress
- % Done changed from 0 to 100
Updated by Marcel Telka over 9 years ago
- Subject changed from Typo or undefined operation in uts/common/cpr/cpr_stat.c to Duplicate assignment in uts/common/cpr/cpr_stat.c
Updated by Electric Monk over 9 years ago
git commit dff8ce8858f30b8b43711766bd0f637548b8d700
Author: Gary Mills <gary_mills@fastmail.fm> 3379 Duplicate assignment in uts/common/cpr/cpr_stat.c Reviewed by: Marcel Telka <marcel@telka.sk> Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com> Approved by: Dan McDonald <danmcd@omniti.com>
Updated by Dan McDonald over 9 years ago
- Status changed from In Progress to Pending RTI
Placeholder...
Updated by Dan McDonald over 9 years ago
- Status changed from Pending RTI to Resolved
Resolved --> see above.
Actions