Project

General

Profile

Bug #3467

mdb_ctf_vread() could be more useful

Added by Christopher Siden almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
cmd - userland programs
Start date:
2013-01-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

From Matt Ahrens's original bug report at Delphix:

mdb_ctf_vread() can fail in many interesting ways.  It should print useful
error messages whenever it fails (with an option to not print).

mdb_ctf_vread() does not translate enums; it should

mdb_ctf_vread() should take the name of the MDB module type, enabling the
module to define exactly which members it needs.  With this functionality, the
MDB_CTF_VREAD_IGNORE_* flags should rarely be needed.

Also, some dcmds are ripe for conversion to use mdb_ctf_vread():
    ::findstack (kthread_t)
    ::dbuf (dmu_buf_impl_t)
    ::spa_config (spa_t)
    ::zio (zio_t)
#1

Updated by Christopher Siden almost 8 years ago

  • Status changed from Pending RTI to Resolved
  • % Done changed from 0 to 100
commit 28e4da2
Author: Matthew Ahrens <mahrens@delphix.com>
Date:   Wed Jan 30 15:02:58 2013

    3465 ::walk ... | ::<dcmd> misinterprets input as symbol names
    3466 ::tsd should handle missing/NULL values better
    3467 mdb_ctf_vread() could be more useful
    3468 mdb enhancements for zfs development
    3470 ::whatis does not print callers from KMF_LITE
    3473 mdb_get_module() returns wrong module
    Reviewed by: Adam Leventhal <ahl@delphix.com>
    Reviewed by: Eric Schrock <eric.schrock@delphix.com>
    Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@nexenta.com>

Also available in: Atom PDF