Project

General

Profile

Actions

Feature #3542

closed

Change LZ4 implementation not to enforce software bitcount

Added by Sašo Kiselkov over 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Low
Category:
zfs - Zettabyte File System
Start date:
2013-02-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

Turns out that my original implementation had an incorrect conclusion about the unavailability of GCC's __builtin_ctz family of bitcount functions. Upon suggestions from Xin Li I retested with builtin's enabled and these functions work just fine in the kernel. This patch changes removes LZ4_FORCE_SW_BITCOUNT so that we get the added speed boost from builtin bitcounts.

Actions #1

Updated by Sašo Kiselkov over 9 years ago

  • Status changed from New to Feedback
Actions #2

Updated by Dan McDonald over 8 years ago

  • Status changed from Feedback to Resolved

Per the author's request, this is now resolved, but thanks to another push.

(the changes in it were made part of
commit d8fa96c3 which fixed 3705 - that's closed now).

Actions

Also available in: Atom PDF