Bug #3544
closed
save-args matcher could be considerably more robust
100%
Description
It'd be far better if the save-args matcher used the DTrace disassembler common code (as libdisasm does), and rather than walking the prologue byte-by-byte, walked actually insn-by-insn
Updated by Rich Lowe over 9 years ago
It turns out to be much more aesthetically pleasing to use libdisasm itself, rather than the common code underlying it, and to split the saveargs stuff out into an (amd64-specific, at present) private libsaveargs (and libstandsaveargs, in the same manner as libdisasm itself and libumem).
This also makes things easier for any other platforms that may need similar facilities (and most others would) and, less bluesky, allows us to be a bit smarter on 32bit x86 in the future should we wish to (and I do, I just haven't found the time.)
Updated by Rich Lowe over 9 years ago
- Status changed from In Progress to Resolved
- % Done changed from 60 to 100
Resolved in 702941c