Project

General

Profile

Bug #3578

transferring the freed map to the defer map should be constant time

Added by Christopher Siden over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2013-02-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

From George Wilson's bug report at Delphix:

In metaslab_sync_done() we have to traverse two different space_maps.
Monitoring this on dcenter I noticed that we're spending more than 10ms
traversing each of these. We should be able to just swap the freed_map and the
defermap and avoid one of the traversals.

History

#1

Updated by Christopher Siden over 6 years ago

  • Status changed from In Progress to Closed
commit 9eb57f7
Author: George Wilson <george.wilson@delphix.com>
Date:   Wed Feb 20 13:30:36 2013

    3578 transferring the freed map to the defer map should be constant time
    3579 ztest trips assertion in metaslab_weight()
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
    Reviewed by: Adam Leventhal <ahl@delphix.com>
    Reviewed by: Christopher Siden <christopher.siden@delphix.com>
    Reviewed by: Richard Elling <richard.elling@dey-sys.com>
    Approved by: Dan McDonald <danmcd@nexenta.com>

Also available in: Atom PDF