illumos gate

module smbadm.c
function smbadm_join_domain()

When a username and password is entered in the "username+password" syntax, the routine does not parse out the username and password correctly. Example: given "username+password" it extracts username="username+" (incorrect) and password="password" (correct).

Also a length check checks username against sizeof (jdi.domain_name), should probably be sizeof (jdi.domain_username).

Finally, not a bug in the parse routine, but all domain join authentication errors seem to result in "failed to find any domain controllers for (domainname)".