parsing bugs in smbadm.c
When a username and password is entered in the "username+password" syntax, the routine does not parse out the username and password correctly. Example: given "username+password" it extracts username="username+" (incorrect) and password="password" (correct).
Also a length check checks username against sizeof (jdi.domain_name), should probably be sizeof (jdi.domain_username).
Finally, not a bug in the parse routine, but all domain join authentication errors seem to result in "failed to find any domain controllers for (domainname)".
Updated by Lee Allen over 9 years ago
Correction! I was completely wrong about this. My password contained dollar signs, that is why it was not parsing correctly. If I escape those symbols it parses fine.
The other two issues are still valid, but I am not sure I would classify them as bugs.