Project

General

Profile

Actions
Copy link

Bug #3729

closed

getifaddrs must learn to stop worrying and love the other address families

Added by Joshua M. Clulow over 9 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
lib - userland libraries
Start date:
2013-04-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
2000

Description

Presently getifaddrs appears to enumerate network interface addresses only from AF_INET and AF_INET6. This is contrary to the expectations of a small set of software (e.g. allegedly ISC dhcpd) which expects this function to deal also in AF_LINK, etc.

Related issues

Has duplicate illumos gate - Bug #11196: getifaddrs does not return MAC addresses (ISC KEA)Closed

Actions
Actions
Copy link
 #1

Updated by Joshua M. Clulow over 9 years ago

NB: After #3728 integrates, there will be a getifaddrs(3SOCKET) which mentions this bug. Once this is fixed, the BUG section should be removed from that manual page.

Actions
Copy link
 #2

Updated by Electric Monk about 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit e34d8872f4a713d904a4b34fb081060d1a7eba62

commit  e34d8872f4a713d904a4b34fb081060d1a7eba62
Author: Sebastian Wiedenroth <wiedi@frubar.net>
Date:   2017-06-21T18:12:05.000Z

    3729 getifaddrs must learn to stop worrying and love the other address families
    Reviewed by: Yuri Pankov <yuri.pankov@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Dan McDonald <danmcd@kebe.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions
Copy link
 #3

Updated by Electric Monk about 5 years ago

git commit f67cf39ba88ad7c4bee81445cc7a7468e0289f01

commit  f67cf39ba88ad7c4bee81445cc7a7468e0289f01
Author: Robert Mustacchi <rm@joyent.com>
Date:   2017-06-26T17:14:00.000Z

    backout: 3729 getifaddrs must learn to stop worrying and love the other address families (breaks consumers)

Actions
Copy link
 #4

Updated by Sebastian Wiedenroth about 5 years ago

This was backed out because consumers have come to depend on this bug.

Namely libuv, while "multi-platform" had a special case for sunos that could not cope with address types other than AF_INET and AF_INET6 beeing returned. This has since been fixed upstream (and released with 1.13.0) but would still break older releases already in use.

I'm looking into the best way to go from here.

Actions
Copy link
 #5

Updated by Rich Lowe about 3 years ago

  • Status changed from Closed to New
Actions
Copy link
 #6

Updated by Gergő Mihály Doma about 3 years ago

  • Has duplicate Bug #11196: getifaddrs does not return MAC addresses (ISC KEA) added
Actions
Copy link
 #7

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 2000
Actions
Copy link
 #8

Updated by Sebastian Wiedenroth 6 months ago

Tested using a small tool that prints the getifaddrs() details.
A binary compiled before booting into a BE with this change does
not show the AF_LINK entries, a recompiled version does.
Created a vnic without an IP interface which was also reported.
Ran `os.networkInterfaces()` in node.js v16.13.2 which worked.

Actions
Copy link
 #9

Updated by Electric Monk 3 months ago

  • Status changed from New to Closed

git commit 3ee592424ed4bb7b850d9adccb9f3c493ce7534b

commit  3ee592424ed4bb7b850d9adccb9f3c493ce7534b
Author: Sebastian Wiedenroth <wiedi@frubar.net>
Date:   2022-05-20T00:04:11.000Z

    3729 getifaddrs must learn to stop worrying and love the other address families
    Portions contributed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions
Copy link

Also available in: Atom PDF