Project

General

Profile

Bug #3743

zfs needs a refcount audit

Added by Will Andrews about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2013-04-23
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

A number of areas are vulnerable to refcount leaks, particularly in error paths. Existing refcount leaks need to be plugged.

Ideally, we should develop a mechanism to check for these types of mistakes, perhaps as a static analyzer extension.

History

#1

Updated by Will Andrews about 6 years ago

Specific areas that currently need to be fixed:
- zap_cursor_fini() is not always called in error cases.
- zap_table_load(): calls dbuf_rele() unconditionally after dbuf_hold().
- dsl_dataset_hold_obj(): dbuf_rele() not called in error case.

#2

Updated by Christopher Siden about 6 years ago

  • Category set to zfs - Zettabyte File System
  • Status changed from New to Closed
  • Assignee set to Christopher Siden
  • % Done changed from 0 to 100
commit b287be1
Author: Will Andrews <will@firepipe.net>
Date:   Tue Jun 11 10:13:38 2013

    3743 zfs needs a refcount audit
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Eric Schrock <eric.schrock@delphix.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Approved by: Christopher Siden <christopher.siden@delphix.com>

Also available in: Atom PDF