Project

General

Profile

Bug #3751

ALUA mode: "/usr/demo/comstar/bin/aluaadm enable 1" sets "ALUA Node" = 0

Added by Hans Rosenfeld over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Start date:
2013-04-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

This is a bug with /usr/demo/comstar/bin/aluaadm; essentially the code portion that sets the nodeid is incorrect as it is documented to accept the node id argument as "aluaadm enable 1" but in fact looks for "aluaadm enable <any single character>1" :

uint8_t node_id = 0;

if (operands[0][1] == '1') {
        node_id = 1;
}

So "aluaadm enable X1" works but "aluaadm enable 1" fails - in the above code [0][1] simply needs changing to [0][0].

History

#1

Updated by Hans Rosenfeld over 6 years ago

  • % Done changed from 90 to 100

The bug and the fix come from Paul Griffiths-Todd. I also included a small manpage fix from Paul.

Webrev: http://cr.illumos.org/~webrev/hans/illumos-3751-webrev/

#2

Updated by Gordon Ross over 6 years ago

  • Status changed from New to Resolved
commit 293058931b0d2be50da82ce72d3249df01389444
Author: Paul Griffiths-Todd <Paul.Griffiths-Todd@high-availability.com>
Date:   Thu Apr 25 21:56:34 2013 +0200

    3751 ALUA mode: "/usr/demo/comstar/bin/aluaadm enable 1" sets "ALUA Node" = 
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
    Reviewed by: SaÊío Kiselkov <skiselkov.ml@gmail.com>
    Reviewed by: Garrett D'Amore <garrett.damore@gmail.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

:100644 100644 5fa1504... 3a8a217... M  usr/src/cmd/stmfproxy/aluaadm/aluaadm.c
:100644 100644 3fe7cd3... 8e9f5d3... M  usr/src/man/man1m/stmfadm.1m

Also available in: Atom PDF