illumos gate

The title has a typo. It should be snprintf(), not sprintf().

There's nothing wrong with using sizeof() that way here.

Yuri Pankov wrote:

There's nothing wrong with using sizeof() that way here.

Unless path is a pointer:

https://github.com/ryao/zfs/blob/c236c99e097f596e85fd1b5de398ce908104a119/cmd/ztest/ztest.c#L2554

Yuri Pankov wrote:

There's nothing wrong with using sizeof() that way here.

Using sizeof on an dynamic allocation is wrong. Here is a small C program that you can compile:

#include <stdlib.h>
#include <stdio.h>

int main (){
char *buffer = malloc(10240);
printf("sizeof buffer = %d\\n", sizeof buffer);
return 0;
}

The output on my system is "sizeof buffer = 8", which is the size of the pointer, not the size of the allocation. We should not be passing the size of the pointer to snprintf().

Igor, thanks for spotting that. Yuri was right. I neglected to notice that ZFSOnLinux had changed this to be a dynamic allocation from Illumos' static allocation when I checked if this patch applied to Illumos. The use of a stack allocation makes the original code fine. It was late at night when I filed this (and early in the morning now), so I missed that. Would someone close this issue? It is invalid.