Project

General

Profile

Actions

Bug #3864

closed

memory leak in the iSCSI code

Added by Christopher Siden almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Category:
comstar - iSCSI/FC/SAS target
Start date:
2013-07-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

From Jeremy Jones's bug report at Delphix:

There appears to be a leak of stmf_svc_req_t structures in the iSCSI code.  The
stmf_svc() thread pulls service requests off of a queue but after it is done
processing a request it does not free it.

To reproduce:

$ zfs create -V 8g domain0/lun0
$ zfs create -V 8g domain0/lun1
$ stmfadm create-lu /dev/zvol/rdsk/domain0/lun0
Logical unit created: 600144F053E18D000000518196B70001
$ stmfadm create-lu /dev/zvol/rdsk/domain0/lun1
Logical unit created: 600144F053E18D000000518196B80002
$ stmfadm add-view 600144F053E18D000000518196B70001
$ stmfadm remove-view -l 600144F053E18D000000518196B70001 0
$ stmfadm add-view 600144F053E18D000000518196B80002
$ reboot -d

Run ::findleaks on the generated dump.

Actions #1

Updated by Christopher Siden almost 9 years ago

  • Status changed from In Progress to Closed
commit 09409df
Author: Jeff Biseda <jeff.biseda@delphix.com>
Date:   Sun Jul 7 19:18:37 2013

    3862 stmf + kstat = kernel panic
    3863 stmf_itl_task_start() must check for ilu->ilu_kstat_io is non-null
    3864 memory leak in the iSCSI code
    Reviewed by: Adam Leventhal <ahl@delphix.com>
    Reviewed by: Jeremy Jones <jeremy@delphix.com>
    Reviewed by: Sebastien Roy <sebastien.roy@delphix.com>
    Reviewed by: Dan McDonald <danmcd@nexenta.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Richard Elling <richard.elling@gmail.com>
    Approved by: Gordon Ross <gwr@nexenta.com>
Actions

Also available in: Atom PDF