Project

General

Profile

Actions

Bug #3942

closed

inject sanity into ipadm tcp buffer size properties

Added by Christopher Siden almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Category:
networking
Start date:
2013-07-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

From Sebastien Roy's original bug report at Delphix:

There are a number of issues with the way that tcp buffer size properties are
presented in ipadm.

1. The properties that represent the default send and receive buffer sizes are
named "send_maxbuf" and "recv_maxbuf".  These are not maximum buffer sizes, but
rather default buffer sizes, and they are thus misnamed.  These should be named
"send_buf" and "recv_buf".

2. While the possible range of values for send_maxbuf and recv_maxbuf is
displayed as 4096-1073741824, there is a hidden property (_max_buf) that
silently caps the effective buffer sizes of new connections.  As such, the
range for send_maxbuf and recv_maxbuf should reflect _max_buf.

3. _max_buf shouldn't be a hidden tunable, as it also restricts the maximum
size that can be passed into SO_SNDBUF and friends.  We should expose a proper
max_buf tunable.

4. While we're dabbling here, we should change the transmit low water mark to
auto-tune to a persentage of the send buffer size instead of having it be a
fixed value.

There will be aliases for the old names of properties for backwards compatibility.

Actions #1

Updated by Christopher Siden almost 8 years ago

  • Status changed from In Progress to Closed
commit 299625c
Author: Sebastien Roy <seb@delphix.com>
Date:   Thu Aug 1 18:47:00 2013

    3942 inject sanity into ipadm tcp buffer size properties
    3943 _snd_lowat_fraction tcp tunable has no effect
    Reviewed by: Adam Leventhal <ahl@delphix.com>
    Reviewed by: Peng Dai <peng.dai@delphix.com>
    Reviewed by: Dan McDonald <danmcd@nexenta.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@nexenta.com>
Actions

Also available in: Atom PDF