Project

General

Profile

Bug #3963

Various incorrect flag handling changes

Added by Prasad Joshi almost 7 years ago. Updated almost 7 years ago.

Status:
New
Priority:
Normal
Assignee:
Category:
-
Start date:
2013-08-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

There are many incorrect flag handling typos similar to https://www.illumos.org/issues/3893.

Opening this BUG to track the changes


Files

History

#1

Updated by Prasad Joshi almost 7 years ago

There are number of flag handling errors specifically,

!expression & constant

should be changed to

!(expression & constant)

The attached patch fixes this problem.

A coccinelle script was used to detect these problems. To know more about Coccinelle please visit http://coccinelle.lip6.fr/

#2

Updated by Prasad Joshi almost 7 years ago

  • % Done changed from 0 to 100
#3

Updated by Marcel Telka almost 7 years ago

Very nice work, Prasad. The attached patch LGTM. Feel free to list me as reviewer.

Also available in: Atom PDF